This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH [3/n]: Add __snseconds_t and __SNSECONDS_T_TYPE


For some reason your mail contains the ChangeLog fragment twice.
There's no need for that.

> 	* bits/types.h (__snseconds_t): New.

Say "New type".

> 	* bits/typesizes.h (__SNSECONDS_T_TYPE): Likewise.

Say "New macro".

> 	* sysdeps/unix/bsd/bsd4.4/freebsd/bits/typesizes.h (__SNSECONDS_T_TYPE):

This line is too long.  Wrap it so the second line starts with the (.

> 	* time/time.h (timespec): Use __snseconds_t on tv_nsec.

It should be "(struct timespec)", i.e. it's always the full proper C
nomenclature for the type.

This change comes chronologically after the typesizes.h changes, i.e.
closer to the top of the file.

In this particular case, it could either be considered part of the same
change and so in the same paragraph (in which case at the end of the
paragraph makes sense), or it could be considered a follow-on change and so
in its own paragraph (in which case that paragraph goes higher up in the
file).

While these two changes are arguably logically separable, they are
sufficiently closely related that it is indeed right for them to be
in one patch (and thus one commit when it goes in).


Thanks,
Roland


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]