This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: PATCH: Use "unsigned long long int" in x86-64 __makecontext
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Richard Henderson <rth at twiddle dot net>
- Cc: "H.J. Lu" <hongjiu dot lu at intel dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Fri, 16 Mar 2012 11:07:45 -0700
- Subject: Re: PATCH: Use "unsigned long long int" in x86-64 __makecontext
- References: <20120316175625.GA7729@intel.com><4F63800A.9030801@twiddle.net>
On Fri, Mar 16, 2012 at 11:01 AM, Richard Henderson <rth@twiddle.net> wrote:
> On 03/16/12 10:56, H.J. Lu wrote:
>> - ?ucp->uc_mcontext.gregs[REG_RIP] = (long int) func;
>> + ?ucp->uc_mcontext.gregs[REG_RIP] = (unsigned long int) func;
>> ? ?/* Setup rbx.*/
>> - ?ucp->uc_mcontext.gregs[REG_RBX] = (long int) &sp[idx_uc_link];
>> - ?ucp->uc_mcontext.gregs[REG_RSP] = (long int) sp;
>> + ?ucp->uc_mcontext.gregs[REG_RBX] = (unsigned long int) &sp[idx_uc_link];
>> + ?ucp->uc_mcontext.gregs[REG_RSP] = (unsigned long int) sp;
>
> At minimum I think these should be uintptr_t.
>
I will do that.
Thanks.
--
H.J.