This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Use "unsigned long long int" in x86-64 __makecontext

> I compared the assembly outputs for both x32 and x86-64.  There
> are no differences between "long int" and "unsigned long int" vs.
> "greg_t" on va_arg.  Here is the patch to use  greg_t exclusively.
> OK to install?

That code looks OK, though (greg_t) after (uintptr_t) is really superfluous
since the target of the assignment is a greg_t anyway.
But please remove the erroneous XXX comment too.

This could be a separate change, but it seems wise to make tst-setcontext.c
try some long int and uintptr_t arguments.


Thanks,
Roland
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]