This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: PATCH: Remove the `q' suffix in x86_64 PTR_MANGLE/PTR_DEMANGLE
- From: Roland McGrath <roland at hack dot frob dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Fri, 16 Mar 2012 15:54:40 -0700 (PDT)
- Subject: Re: PATCH: Remove the `q' suffix in x86_64 PTR_MANGLE/PTR_DEMANGLE
- References: <20120316222621.GA1543@intel.com>
That looks fine to me.
But don't you want to rotate by 9 rather than 17 when dealing with a 32-bit
pointer, like the i386 version does?
It could be genericized here by using a "i" constraint on an input argument
that you compute from sizeof (void *).
Thanks,
Roland