This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: PATCH: Replace long with long long in sysdeps/x86_64/dl-tls.h
On Wed, Mar 21, 2012 at 2:55 PM, Roland McGrath <roland@hack.frob.com> wrote:
> That is probably fine. ?But it really seems to me that we should not be
> using vague types like "long" and "long long", when we mean very specific
> things. ?It's better to use uint64_t or uintptr_t, etc., as appropriate to
> what exactly it is you mean in a particular use.
>
>
Here is the patch to implement it. Tested on Linux/x86-64 and Linux/x32.
OK to install?
Thanks.
--
H.J.
2012-03-22 H.J. Lu <hongjiu.lu@intel.com>
* sysdeps/x86_64/dl-tls.h (dl_tls_index): Replace unsigned long
with uint64_t.
diff --git a/sysdeps/x86_64/dl-tls.h b/sysdeps/x86_64/dl-tls.h
index 4de5815..56162ee 100644
--- a/sysdeps/x86_64/dl-tls.h
+++ b/sysdeps/x86_64/dl-tls.h
@@ -20,8 +20,8 @@
/* Type used for the representation of TLS information in the GOT. */
typedef struct dl_tls_index
{
- unsigned long int ti_module;
- unsigned long int ti_offset;
+ uint64_t ti_module;
+ uint64_t ti_offset;
} tls_index;