This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Move sysdeps/x86_64/Implies to sysdeps/x86_64/64


On Thu, Mar 22, 2012 at 11:11 AM, Roland McGrath <roland@hack.frob.com> wrote:
> It seems to me that everything except wordsize-NN should be in a shared
> file rather than being repeated in x32/Implies and 64/Implies.
>
> Can you elaborate on why you need to add x86_64/fpu explicitly
> rather than letting the standard configure logic do it?
>
> If we are actually putting x86_64/fpu in the list unconditionally, then I
> don't really see a point to the subdirectory at all. ?If there can never be
> a --without-fp configuration for x86_64, all the x86_64/fpu contents can
> just move up into x86_64/.

Good point.

> I don't like the idea of a proliferation of synthetic subdirectories like
> x86_64/common just to get around the semantics of Implies files. ?Perhaps
> it would be better to extend the syntax of Implies files with a way to say
> that a directory comes after parents rather than before.
>

For x86-64, base_machine == x86_64 and machine can be either
x86_64/64 or x86_64/x32.  For

[hjl@gnu-6 glibc-x32]$ cat sysdeps/x86_64/Implies
ieee754/ldbl-96
ieee754/dbl-64/wordsize-64
ieee754/dbl-64
ieee754/flt-32
[hjl@gnu-6 glibc-x32]$ cat sysdeps/x86_64/64/Implies
wordsize-64
[hjl@gnu-6 glibc-x32]$

to work correctly, we need to concatenate them as a single Implies:

wordsize-64
ieee754/ldbl-96
ieee754/dbl-64/wordsize-64
ieee754/dbl-64
ieee754/flt-32

Can we have Imples.prepend, which will be preprended is its parent
Implies?

-- 
H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]