This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fix nptl/tst-cond1{6,7} on 32-bit with many cpus
From: Chris Metcalf <cmetcalf@tilera.com>
Date: Mon, 26 Mar 2012 17:51:48 -0400
> On 3/26/2012 5:34 PM, David Miller wrote:
>> We still need to take __getpagesize() into account, because some
>> PTHREAD_STACK_MIN definitions are smaller than the largest possible page
>> size on the respective architecture. And it also turns out that
>> tst-cond18 has the same problem as tst-cond16 and tst-cond17.
>
> We have a similar (though simpler) fix for our system, where we have 64
> cores and (on our older systems) only a 32-bit VA space. We've been using
> this patch, since 1MB stacks are clearly way bigger than any practical
> need, but still total up to way smaller than the available VA space.
Sparc can have 4MB page size, and your change would thus fail in that
configuration.
That's why in the patch being proposed we're using the pthread stack
min define in concert with __getpagesize(), so that it works in any
possible situation.