This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Move sysdeps/x86_64/Implies to sysdeps/x86_64/64


On Sun, Apr 8, 2012 at 5:38 PM, Chris Metcalf <cmetcalf@tilera.com> wrote:
> On 4/8/2012 10:44 AM, H.J. Lu wrote:
>> On Sat, Apr 7, 2012 at 8:19 AM, Joseph S. Myers <joseph@codesourcery.com> wrote:
>>> On Fri, 6 Apr 2012, H.J. Lu wrote:
>>>
>>>> For x86-64, with Implies-after, the search order can only be
>>>>
>>>> ieee754/ldbl-96
>>>> ieee754/dbl-64/wordsize-64
>>>> ieee754/dbl-64
>>>> ieee754/flt-32
>>>> wordsize-64
>>>>
>>>> not
>>>>
>>>> wordsize-64
>>>> ieee754/ldbl-96
>>>> ieee754/dbl-64/wordsize-64
>>>> ieee754/dbl-64
>>>> ieee754/flt-32
>>> Thanks for giving a concrete different in orders. ?The next question is:
>>> why does that difference matter for x32? ?(If it doesn't, you need to give
>>> an example of a case where the order *does* matter and you can't get the
>>> order you want.)
>> It does matter for both x32 and x86-64. ?I created hjl/order branch and
>> moved wordsize-64 to sysdeps/x86_64/64/Implies:
>
> For what it's worth, I struggled with this for tilepro (32-bit) and tilegx
> (64-bit or 32-bit). ?I ended up moving all the Implies stuff to the
> leaf-most nodes, in general. ?sysdeps/tile just has the ieee754 implies.
> So sysdeps/tile/tilegx has no Implies, despite it seeming like the obvious
> place to put some things (like tile/tilegx and tile), and instead I put
> them in tile/tilegx/tilegx{32,64}. ?I did the same thing under
> sysdeps/unix/sysv/linux. ?Confusing but eventually it worked.
>

I checked a patch:

http://sourceware.org/git/?p=glibc.git;a=patch;h=a2e3214d007c8c7cf6070fac053a1ff70c1b08b1

into hjl/order branch to combine Implies from x86_64/64 with
Implies from x86_64.  Can you check if it works for tile?

Thanks.

-- 
H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]