This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/3] Define libgcc soname in make scripts and not in aheader


On Mon, 16 Apr 2012 18:04:03 +0530, Siddhesh wrote:
> On Fri, 13 Apr 2012 09:04:00 -0700 (PDT), Roland wrote:
> > Continuation line indents to line up with the *, not after it.
> > 
> > > 	* sysdeps/gnu/unwind-resume.c: Ditto.
> > 
> > We say "Likewise."
> > 
> > 
> > Aside from those nits, this change looks OK to me.
> > But I haven't given it very thorough attention.
> > 
> 
> Thanks, I've fixed those in my local copy and it is ready to commit.
> Can one of the ports maintainers review this too? An analogous change
> will be needed in ports for hppa and m68k, although not having the
> change right away will not break the build.
> 

I'm sorry this will in fact break ports build without the change; I did
not think that through completely. Carlos, Andreas Schwab, do you guys
think I can put the patch in and you guys fix the ports build with the
change? The change only affects m68k and hppa in ports AFAICT.

--
Siddhesh


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]