This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 2/3] Do check-execstack test using readelf rather than a build-time C program.
On Tuesday, May 01, 2012 19:40:43 Roland McGrath wrote:
> ---
> ChangeLog | 10 +++
> elf/Makefile | 41 +++++++----
> elf/check-execstack.c | 162
> ------------------------------------------- scripts/check-execstack.awk
> | 52 ++++++++++++++
> 4 files changed, 88 insertions(+), 177 deletions(-)
> delete mode 100644 elf/check-execstack.c
> create mode 100644 scripts/check-execstack.awk
>
> diff --git a/ChangeLog b/ChangeLog
> index 7755e67..634d96c 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,5 +1,15 @@
> 2012-05-01 Roland McGrath <roland@hack.frob.com>
>
> + * scripts/check-execstack.awk: New file.
> + * elf/Makefile ($(objpfx)check-execstack): Target removed.
> + (check-execstack-CFLAGS): Variable removed.
> + ($(objpfx)check-execstack.h): Target removed.
> + ($(objpfx)execstack-default): New target.
> + (generated): Add that instead of check-execstack.h.
> + ($(all-built-dso:=.phdr)): New static pattern rule.
> + (generated): Add those targets.
> + * elf/check-execstack.c: File removed.
> +
Roland, I just run make clean and the .phdr and .dyn files are not removed.
aj@byrd:/home/aj/build/glibc/testing> ls nptl
libpthread.so.dyn libpthread.so.jmprel libpthread.so.phdr
pthread_atfork.oS
aj@byrd:/home/aj/build/glibc/testing> ls locale
libBrokenLocale.so.dyn libBrokenLocale.so.phdr
aj@byrd:/home/aj/build/glibc/testing>
Is something broken with your Makefile?
Andreas
--
Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126