This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix for logb/logbf/logbl (bz 13954/13955/13956)


From: "Joseph S. Myers" <joseph@codesourcery.com>
Date: Fri, 4 May 2012 13:45:17 +0000 (UTC)

> On Fri, 4 May 2012, Adhemerval Zanella wrote:
> 
>> On 05/04/2012 08:08 AM, Joseph S. Myers wrote:
>> > On Thu, 3 May 2012, Adhemerval Zanella wrote:
>> >
>> >> +      int m1 = (hx == 0) ? 0 : __builtin_clzl (hx);
>> >> +      int m2 = (lx == 0) ? 0 : __builtin_clzl (lx);
>> > hx and lx are 64-bit numbers.  To work for 32-bit platforms as well as 
>> > 64-bit, try using __builtin_clzll instead of __builtin_clzl.
>> >
>> Thanks for the tip, I replaced on ldbl-128ibm and it seems ok in my testings. 
>> Should I resend the patch or wait for some confirmation on s390 and sparc?
> 
> I advise resending as that will make it easier for people to be sure what 
> they are testing is exactly what would be committed.

Indeed.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]