This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Use -frounding-math for math testsuite
> #define SETUP_PIC_REG_LEAF(reg, tmp) \
> SPARC_PIC_THUNK(reg) \
> - sethi %hi(_GLOBAL_OFFSET_TABLE_-4), %##reg; \
> mov %o7, %##tmp; \
Since this exact sequence:
> + sethi %hi(_GLOBAL_OFFSET_TABLE_-4), %##reg; \
> call __sparc_get_pc_thunk.reg; \
> or %##reg, %lo(_GLOBAL_OFFSET_TABLE_+4), %##reg; \
must appear together for subtle reasons, it seems wise to put it
into its own macro with a comment saying that it's important that
it not be broken up (and why)
Conversely, you could just litter the code with some local labels and use
-(1f-0b) sorts of calculations instead of -4. Then you could schedule the
instructions however you want without breaking the semantics. The use of
the labels would also serve as implicit documentation about what the magic
constant is needed for. Seems better that way to me.
Thanks,
Roland