This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Make sunrpc code available for building again
- From: Roland McGrath <roland at hack dot frob dot com>
- To: Andreas Jaeger <aj at suse dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Wed, 9 May 2012 13:31:10 -0700 (PDT)
- Subject: Re: [PATCH] Make sunrpc code available for building again
- References: <ho1umtbgh6.fsf@byrd.suse.de><4FAAD289.8060604@suse.com>
> +/* Define if obsolete rpc code should be made for user level code to link
> + against. */
Put RPC in caps.
"make available"
"user-level"
> + /* libc_hidden_nolink_sunrpc should only get used in sunrpc code .*/
Typo on the . placement.
The substantive bits look OK to me, but I haven't looked at the context
closely.
Thanks,
Roland