This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Sign extend relocation result to 64bit for R_X86_64_DTPOFF64/R_X86_64_TPOFF64


On Wed, May 9, 2012 at 3:58 PM, Roland McGrath <roland@hack.frob.com> wrote:
>> > Sorry I was not clear. ?I just meant a local temporary in those cases to
>> > avoid having the same calculation on both forks of the #if, not anything
>> > superfluous.
>
> You still didn't do this change. ?Please do it.
>
> Use the standard form in log entries for code with #if:
>
> ? ? ? ?(elf_machine_rela) [__ILP32__]:
>
> Also, say "64 bits" in the log entry, not "64bit".
>
>

Here is the new patch.  Tested on Linux/x86-64.   Does it look OK?

Thanks.


-- 
H.J.

Attachment: libc-x32-tls-2.patch
Description: Binary data


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]