This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On Mon, May 14, 2012 at 3:39 PM, Roland McGrath <roland@hack.frob.com> wrote: >> Here is the patch with the shlib-versions changes. ?OK to install? >> Tested on Linux/x86-64. > > You didn't add comments to the new files as I asked. > Please do that. > > I'm not sure there is really any need to leave behind those new comments in > the top-level shlib-versions file. ?I think we will eventually move to > having all the per-machine lines in sysdeps files, so x86_64 is not really > special in this regard. > > The DEFAULT lines in the new files have the wrong spacing (too many spaces > where there should be just a tab). ?The existing shlib-versions file has > (the right number of) spaces where there should be a tab, but that's no > reason to propagate the error to the new files. > Here is the updated patch. Does it look OK? Thanks. -- H.J.
Attachment:
libc-x32-abi-a.patch
Description: Binary data
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |