This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: PATCH: Use __syscall_slong_t in bits/timex.h
- From: Roland McGrath <roland at hack dot frob dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Thu, 17 May 2012 14:59:20 -0700 (PDT)
- Subject: Re: PATCH: Use __syscall_slong_t in bits/timex.h
- References: <20120517124236.GA8518@intel.com>
Why did you move the comments from end-of-line to prior-line?
Comments on fields are much easier to read when they're end-of-line.
M-; will make them all line up again (or use tabs if you're not using
Emacs). If a few lines got too long, then you can make their comments
start just one space after the ; instead of lining them up, so the
lines still fit in under 80 columns. If some are still too long, you
can probably abbreviate the text a little. Only if all that fails
should you move a comment from end-of-line to prior-line.
Thanks,
Roland