This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Add x86-64 x86_64/bits/statvfs.h


> Like this?  I am trying to avoid touch all other wordsize.h files.

Pretty much, yes.

> 	* sysdeps/unix/sysv/linux/bits/statvfs.h (_STATVFSBUF_F_UNUSED):
> 	Don't define if __SYSCALL_WORDSIZE is 64.

Write "if [__SYSCALL_WORDSIZE != 32]" to be clear that it's an #if
condition (the brackets), and to be precise about what the actual
condition is.

> -#if __WORDSIZE == 32
> +#if __WORDSIZE == 32 && (!defined __SYSCALL_WORDSIZE ||
> __SYSCALL_WORDSIZE == 32)

[It looks like your patch got word-wrapped in pasting into the mail.]

> +#ifdef __x86_64__
> +# define __SYSCALL_WORDSIZE		64
> +#endif

Please give it a comment.


Thanks,
Roland


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]