Re: PATCH: Add x32 arch_prctl support

["H. Peter Anvin" <hpa at zytor dot com>]

Yes, please.  Make it clear it was an obsolete interface which should never have been ported to x32.

"H.J. Lu" <hjl.tools@gmail.com> wrote:

>On Mon, May 21, 2012 at 8:57 PM, H. Peter Anvin <hpa@zytor.com> wrote:
>> On 05/21/2012 08:29 PM, H.J. Lu wrote:
>>>
>>> The question is how fast we can to get this patch
>>>
>>> diff --git a/arch/x86/kernel/ptrace.c b/arch/x86/kernel/ptrace.c
>>> index 685845c..cf11783 100644
>>> --- a/arch/x86/kernel/ptrace.c
>>> +++ b/arch/x86/kernel/ptrace.c
>>> @@ -1211,12 +1211,6 @@ static long x32_arch_ptrace(struct
>task_struct *child,
>>> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â0, sizeof(struct
>user_i387_struct),
>>> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Âdatap);
>>>
>>> - Â Â Â Â Â Â /* normal 64bit interface to access TLS data.
>>> - Â Â Â Â Â Â Â ÂWorks just like arch_prctl, except that the
>arguments
>>> - Â Â Â Â Â Â Â Âare reversed. */
>>> - Â Â case PTRACE_ARCH_PRCTL:
>>> - Â Â Â Â Â Â return do_arch_prctl(child, data, addr);
>>> -
>>> Â Â Â default:
>>> Â Â Â Â Â Â Â return compat_ptrace_request(child, request, addr,
>data);
>>> Â Â Â }
>>>
>>> into Linux kernel.
>>>
>>
>> We can probably get it into 3.4.1.
>>
>
>That will be great.  Should I prepare a kernel patch?
>
>Thanks.
>
>-- 
>H.J.

-- 
Sent from my mobile phone. Please excuse brevity and lack of formatting.