This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: PATCH: PR libc/12495: Malloc fails if MALLOC_ALIGNMENT > 2 * SIZE_SZ
- From: Roland McGrath <roland at hack dot frob dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: Daniel Jacobowitz <drow at false dot org>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Thu, 24 May 2012 11:45:16 -0700 (PDT)
- Subject: Re: PATCH: PR libc/12495: Malloc fails if MALLOC_ALIGNMENT > 2 * SIZE_SZ
- References: <20120524032803.GA18165@intel.com>
> 2012-03-14 H.J. Lu <hongjiu.lu@intel.com>
>
> PR libc/12495
> * malloc/malloc.c (sYSMALLOc): Don't update correction with
> front_misalign.
>
> 2007-11-30 Daniel Jacobowitz <dan@codesourcery.com>
>
> PR libc/12495
> * malloc/malloc.c (SMALLBIN_CORRECTION): New.
> (MIN_LARGE_SIZE, smallbin_index): Use it to handle 16-byte alignment.
> (largebin_index_32_big): New.
> (largebin_index): Use it for 16-byte alignment.
> (sYSMALLOc): Handle MALLOC_ALIGNMENT > 2 * SIZE_SZ.
Merge these into one entry with the current date and both names. I
think <drow@false.org> is the proper address to use for Daniel now,
but he can confirm.
Use "[BZ #12495]" as per convention.
I don't really understand the malloc code in sufficient detail to judge the
change without a lot of code-reading. I'm pretty well willing to take your
and Daniel's word on it, but if someone else here can review it that
would be best.
Thanks,
Roland