This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Using __chk_fail from libstdc++


On 6/8/2012 7:03 AM, Joseph S. Myers wrote:
> On Mon, 4 Jun 2012, Carlos O'Donell wrote:
> 
>> On 6/4/2012 3:51 AM, Florian Weimer wrote:
>>> On 06/01/2012 10:23 PM, Roland McGrath wrote:
>>>>> Perhaps it is possible to express this in a test case?
>>>>
>>>> Good point.  It sounds to me like you or Mike just volunteered. ;-)
>>>
>>> It turns out that there already is a test case which checks this implicitly.  I think adding a comment to it is sufficient.
>>>
>>> 2012-06-04  Florian Weimer  <fweimer@redhat.com>
>>>
>>>     * debug/test-strcpy_chk.c: Mention __chk_fail ABI test.
>>>
>>
>> This looks good to me, but we are in 2.16 freeze right now.
>>
>> Could you please file a BZ for glibc, and add target milestone 2.17, 
>> that way we can check this in after the freeze.
> 
> I don't think this sort of change to a comment in a single file needs to 
> be delayed because of the freeze.  (Delaying the ASM_GLOBAL_DIRECTIVE 
> change *is* appropriate, since that's a large change (with some inevitable 
> risk), and requires corresponding ports changes, and we want to stabilize 
> ports during the freeze without them needing to keep chasing a moving 
> target.)
> 

There are both direct and indirect benefits here.

The direct benefit is that it's one less patch I have to 
review going onto trunk.

The indirect benefit is that we get the community into the 
habit and discipline of setting aside trivial changes to 
focus on stabilizing trunk.

Does that make sense?

I don't mind if this patch gets checked into trunk, but
please work with Florian to ensure that it goes in without
error.

Cheers,
Carlos.
-- 
Carlos O'Donell
Mentor Graphics / CodeSourcery
carlos_odonell@mentor.com
carlos@codesourcery.com
+1 (613) 963 1026


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]