Re: [PATCH v4] fix warnings in sys/select.h fortification with -Wsign-conversion

[Mike Frysinger <vapier at gentoo dot org>]

On Saturday 09 June 2012 11:36:29 Paul Eggert wrote:
> On 06/09/2012 06:30 AM, Carlos O'Donell wrote:
> > If nobody else objects please check this in on Monday.
> 
> I object to this change, on the same grounds that I
> objected when the same change was proposed last month
> by Paul Pluzhnikov: the patch may mask a later bug if
> someone mistakenly invokes the macro with D being a pointer.

in all cases where this is used, trying to use a pointer will trigger a build 
failure.  while it's still a minor concern, i don't think it'll come up in 
practice seeing as the fdset API is pretty much done at this point.

> Paul came up with a better patch, which doesn't have this
> problem, and I propose that it be installed instead.

it has slightly more overhead, but probably won't be that big of a deal in 
practice.
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.