This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Update sysdeps/x86_64/fpu_control.h

> > Why *&? ?That seems like a no-op. ?There should be a comment explaining the
> 
> "*&" was added by Ulrich on Aug 26, 1996,  I couldn't find anything beyond
> that.  It could be a workaround for a compiler bug.

And so it is.  Just a comment saying so is enough.

> > need for volatile.
> 
> __volatile__ was added by
> 
> http://sourceware.org/ml/libc-alpha/2004-11/msg00150.html

That should have added a comment saying why it's necessary (as we have some
similar comments somewhere else about the same issue).  Since it didn't,
add the comment now.


Thanks,
Roland
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]