This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Faster strn?cat
Ondrej,
Do you have a baseline number for the speed of str*cat before your patch?
Have you added the baseline and new numbers to the wiki so we can use
them to check against future submissions?
On Sat, Jun 16, 2012 at 3:32 PM, Ondrej Bilka <neleai@seznam.cz> wrote:
> ---
> ?string/strcat.c ? ? ? ? ? ? ? ? ? ?| ? 23 +---
> ?string/strncat.c ? ? ? ? ? ? ? ? ? | ? 55 +-------
> ?sysdeps/x86_64/multiarch/strcat.S ?| ? 84 ------------
> ?sysdeps/x86_64/multiarch/strncat.S | ? ?3 -
> ?sysdeps/x86_64/strcat.S ? ? ? ? ? ?| ?259 ------------------------------------
> ?5 files changed, 5 insertions(+), 419 deletions(-)
> ?delete mode 100644 sysdeps/x86_64/multiarch/strcat.S
> ?delete mode 100644 sysdeps/x86_64/multiarch/strncat.S
> ?delete mode 100644 sysdeps/x86_64/strcat.S
Needs a ChangeLog.
> diff --git a/string/strcat.c b/string/strcat.c
> index f9e4bc6..dc8f3a4 100644
> --- a/string/strcat.c
> +++ b/string/strcat.c
> @@ -1,4 +1,4 @@
> -/* Copyright (C) 1991, 1997, 2003 Free Software Foundation, Inc.
> +/* Copyright (C) 1991, 1997, 2003, 2012 Free Software Foundation, Inc.
Merge copyright years.
In general see:
http://sourceware.org/glibc/wiki/Contribution%20checklist
The rest of the patch is looking good, but we're in the middle of the
2.16 code freeze.
Could you please file a patch for this enhancement and mark it target
milestone 2.17?
Then we can look at it once we come out of the freeze at the end of the month.
Cheers,
Carlos.