This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH,HURD] mach: compliance fixes for nanosleep
- From: Roland McGrath <roland at hack dot frob dot com>
- To: Pino Toscano <toscano dot pino at tiscali dot it>
- Cc: libc-alpha at sourceware dot org, bug-hurd at gnu dot org
- Date: Fri, 20 Jul 2012 10:37:28 -0700 (PDT)
- Subject: Re: [PATCH,HURD] mach: compliance fixes for nanosleep
- References: <201204281729.10321.toscano.pino@tiscali.it>
In a log entry, write a local variable name as FOO rather than `foo'.
Write 'remaining != NULL' in tests. Fix the existing cases while you're
there.
If the second __gettimeofday calls, return failure as it did before.
Since I've just seen it repeated here and in your select change, it seems
worthwhile to add internal inlines for converting timeval/timespec to
mach_msg_timeout_t with the EINVAL check. So if you're looking for more
cleanup to do, that's a worthwhile thing to pursue. But you don't have to
do that before completing this change unless you want to.
Thanks,
Roland