This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH x86_64 only: optimize sinf and cosf with SSE2


On 2012.08.09 at 10:39 +0200, Andreas Jaeger wrote:
> On Thursday, August 09, 2012 12:16:06 Dmitrieva Liubov wrote:
> > Repost of the patch with opimized SINF and COSF for x86_64.
> > 
> > http://sourceware.org/ml/libc-alpha/2012-06/msg00692.html
> > 
> > We are looking forward to accepting and releasing this.
> 
> Btw. if you could look at this bugreport as well and provide an 
> optimized sincos implementation, it would be appreciated:
> http://sourceware.org/bugzilla/show_bug.cgi?id=14412
> 
> Just a few comments on your submission:
> 
> * Please add a copyright header.
> * Instead of defining EDOM, I suggest to:
> #include <bits/errno.h>
> 
> * For your comments, follow the usual style - with two spaces after "." 
> or "?" - and no space before

Also ASM_TYPE_DIRECTIVE{,_PREFIX} was removed a few days ago (commit
b67e9372b28ef33). Please use ".type L(FOO),@object" instead.

-- 
Markus


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]