This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] alpha, ia64, m68k, mips, sh, sparc: *_gnu_pltentershould allow modification of struct La_*_regs.
- From: David Miller <davem at davemloft dot net>
- To: carlos_odonell at mentor dot com
- Cc: libc-alpha at sourceware dot org, Thomas_Schwinge at mentor dot com,joseph at codesourcery dot com, rth at twiddle dot net, vapier at gentoo dot org
- Date: Wed, 15 Aug 2012 19:47:27 -0700 (PDT)
- Subject: Re: [PATCH] alpha, ia64, m68k, mips, sh, sparc: *_gnu_pltentershould allow modification of struct La_*_regs.
- References: <502C3FF9.7050307@mentor.com>
From: Carlos O'Donell <carlos_odonell@mentor.com>
Date: Wed, 15 Aug 2012 20:34:01 -0400
>
> The *_gnu_pltenter interface allows the modification of the incoming
> set of registers in struct La_*_regs, that is to say that the 5th
> argument of la_*_pltenter() is non-constant.
>
> This was not always the case, but it is the case now and has been
> since it was silently changed in commit
> 2413fdba7a02ba8916f75d17199a6e9133a8f7b0.
>
> Removing const from the 5th argument conforms with the Solaris interface:
> http://docs.oracle.com/cd/E19082-01/819-0690/chapter6-1242/index.html
>
> Removing const for alpha, ia64, m68k, mips, sh, and sparc conforms
> with what the other machines in glibc are already doing.
>
> I haven't tested this, but I don't think anything should go wrong
> given the wide usage of the non-const version right now. We could also
> do with a better test case that does something with the registers.
> For now I'm content to cleanup the definition in ldsodefs.h.
>
> OK to commit?
Looks fine on the sparc side.