This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[committed] Fix linker-debugger interface


Carlos O'Donell wrote:
> On 8/16/2012 12:33 PM, Roland McGrath wrote:
> > > 2012-08-16  Gary Benson  <gbenson@redhat.com>
> > >
> > > 	* elf/dl-close.c (_dl_close_worker): Also set r->r_map when
> > >           unmapping the first object in a namespace.
> > 
> > The second line should be intended with just one tab, so it lines
> > up under the * of the first line.

Ah, this is what happens when you update ChangeLogs in diff-mode :)

> > Otherwise the change is fine.
> 
> I reviewed _dl_close_worker and the change looks correct.
> 
> I've often wondered if r_debug is correct in all cases and here's
> a case where it isn't.

This error was hidden previously as it only happens in namespaces
other than LM_ID_BASE, which were not visible through the original
interface.

> Are you able to check this in yourself?

Yes, thank you, I have done so.

Thanks,
Gary

-- 
http://gbenson.net/

Attachment: patch
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]