This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH][BZ #14516] Don't make ttyname fail if procfs is unavailable
- From: "Carlos O'Donell" <carlos at systemhalted dot org>
- To: Siddhesh Poyarekar <siddhesh at redhat dot com>
- Cc: libc-alpha at sourceware dot org, Masahiro Matsuya <mmatsuya at redhat dot com>
- Date: Sat, 25 Aug 2012 11:43:24 -0400
- Subject: Re: [PATCH][BZ #14516] Don't make ttyname fail if procfs is unavailable
- References: <20120824145037.4611785a@spoyarek><20120824200541.3c2dc4a7@spoyarek>
On Fri, Aug 24, 2012 at 10:35 AM, Siddhesh Poyarekar
<siddhesh@redhat.com> wrote:
> Ugh, sorry, I forgot to make an analogous change to ttyname_r. Here's
> an updated patch with it. I have the testsuite running right now. OK to
> commit if there are no regressions?
>
> Regards,
> Siddhesh
>
> ChangeLog:
>
> [BZ #14516]
> * sysdeps/unix/sysv/linux/ttyname.c (ttyname): Don't return
> failure if reading from procfs failed.
> * sysdeps/unix/sysv/linux/ttyname_r.c (ttyname_r): Likewise.
Still looks good to me.
Check it in on Tuesday if nobody objects.
I'd like to see if anyone else has any more comments about this.
Cheers,
Carlos.