Re: [PATCH] Define several new NT_ constant for ELF core files.

[Carlos O'Donell <carlos_odonell at mentor dot com>]

On 8/29/2012 6:44 AM, Petr Machata wrote:
> 2012-08-29  Petr Machata  <pmachata@redhat.com>
> 
> 	* elf/elf.h (NT_S390_HIGH_GPRS): New macro.
> 	(NT_S390_TIMER, NT_S390_TODCMP, NT_S390_TODPREG): Likewise.
> 	(NT_S390_CTRS, NT_S390_PREFIX, NT_S390_LAST_BREAK): Likewise.
> 	(NT_S390_SYSTEM_CALL, NT_ARM_VFP): Likewise.
> 
> diff --git a/elf/elf.h b/elf/elf.h
> index 6c85f92..41fc3bd 100644
> --- a/elf/elf.h
> +++ b/elf/elf.h
> @@ -622,6 +622,15 @@ typedef struct
>  #define NT_386_TLS	0x200		/* i386 TLS slots (struct user_desc) */
>  #define NT_386_IOPERM	0x201		/* x86 io permission bitmap (1=deny) */
>  #define NT_X86_XSTATE	0x202		/* x86 extended state using xsave */
> +#define NT_S390_HIGH_GPRS	0x300	/* s390 upper register halves */
> +#define NT_S390_TIMER	0x301		/* s390 timer register */
> +#define NT_S390_TODCMP	0x302		/* s390 TOD clock comparator register */
> +#define NT_S390_TODPREG	0x303		/* s390 TOD programmable register */
> +#define NT_S390_CTRS	0x304		/* s390 control registers */
> +#define NT_S390_PREFIX	0x305		/* s390 prefix register */
> +#define NT_S390_LAST_BREAK	0x306	/* s390 breaking event address */
> +#define NT_S390_SYSTEM_CALL	0x307	/* s390 system call restart data */
> +#define NT_ARM_VFP	0x400		/* ARM VFP/NEON registers */
>  
>  /* Legal values for the note segment descriptor types for object files.  */
>  
> -- 

Thanks for the patch!

I've synched one more field.

Andreas,

Could you please ACK for s390 since there are extra NT_* entries there for s390.

Joseph,

Could you please ACK for ARM since there are extra NT_* entries there for ARM.

Once I get an ACK from each of you I'll check this in.

v2
- Add alias for NT_PRREGSET to match kernel.
- Verified all NT_* macros matched Linux kernel 3.6.0-rc3 values.

2012-08-31  Petr Machata  <pmachata@redhat.com>
	    Carlos O'Donell  <carlos_odonell@mentor.com>

	* elf/elf.h (NT_PRFPREG, NT_S390_HIGH_GPRS): New macro.
	(NT_S390_TIMER, NT_S390_TODCMP, NT_S390_TODPREG): Likewise.
	(NT_S390_CTRS, NT_S390_PREFIX, NT_S390_LAST_BREAK): Likewise.
	(NT_S390_SYSTEM_CALL, NT_ARM_VFP): Likewise.

diff --git a/elf/elf.h b/elf/elf.h
index 6c85f92..3e488ec 100644
--- a/elf/elf.h
+++ b/elf/elf.h
@@ -601,6 +601,7 @@ typedef struct
 
 #define NT_PRSTATUS	1		/* Contains copy of prstatus struct */
 #define NT_FPREGSET	2		/* Contains copy of fpregset struct */
+#define NT_PRFPREG	2		/* Contains copy of fpregset struct */
 #define NT_PRPSINFO	3		/* Contains copy of prpsinfo struct */
 #define NT_PRXREG	4		/* Contains copy of prxregset struct */
 #define NT_TASKSTRUCT	4		/* Contains copy of task structure */
@@ -622,6 +623,15 @@ typedef struct
 #define NT_386_TLS	0x200		/* i386 TLS slots (struct user_desc) */
 #define NT_386_IOPERM	0x201		/* x86 io permission bitmap (1=deny) */
 #define NT_X86_XSTATE	0x202		/* x86 extended state using xsave */
+#define NT_S390_HIGH_GPRS	0x300	/* s390 upper register halves */
+#define NT_S390_TIMER	0x301		/* s390 timer register */
+#define NT_S390_TODCMP	0x302		/* s390 TOD clock comparator register */
+#define NT_S390_TODPREG	0x303		/* s390 TOD programmable register */
+#define NT_S390_CTRS	0x304		/* s390 control registers */
+#define NT_S390_PREFIX	0x305		/* s390 prefix register */
+#define NT_S390_LAST_BREAK	0x306	/* s390 breaking event address */
+#define NT_S390_SYSTEM_CALL	0x307	/* s390 system call restart data */
+#define NT_ARM_VFP	0x400		/* ARM VFP/NEON registers */
 
 /* Legal values for the note segment descriptor types for object files.  */
 
--

Cheers,
Carlos.
-- 
Carlos O'Donell
Mentor Graphics / CodeSourcery
carlos_odonell@mentor.com
carlos@codesourcery.com
+1 (613) 963 1026