This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: secure getenv testcase...

On Tuesday, September 04, 2012 09:26:36 Florian Weimer wrote:
> On 09/03/2012 10:16 PM, David Miller wrote:
> >> Can you provide more details about the failure?  I'm not sure where
> >> to start looking.
> > 
> > SGID failed: GID and EGID match (1000)
> > Unexpected exit status 512 from child process
> 
> Looks like your /tmp is mounted nosuid.  The attached patch ignores
> this failure and prints a warning.

A note on style:
> [...]
> +	  /* This can happen if the file system is mounted nosuid. */

Two spaces after the "." and before the "*/", please add an extra one.

> +	  fprintf (stderr, "SGID failed: GID and EGID match (%jd)\n",

Thanks,
Andreas
-- 
 Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
  SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
    GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]