This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] BZ #14251: Add name_to_handle_at, open_by_handle etc. to PowerPC bits/fcntl.h.
On Sunday, September 09, 2012 11:38:08 Carlos O'Donell wrote:
> On 9/9/2012 12:29 AM, Khem Raj wrote:
> > ---
> > 2012-09-08 Khem Raj <raj.khem@gmail.com>
> >
> > [BZ #14251]
> > * sysdeps/unix/sysv/linux/powerpc/bits/fcntl.h: Define struct
> > file_handle and MAX_HANDLE_SZ. Declare name_to_handle_at and
> > open_by_handle.
>
> Imagine your email is like an assignment, you need to do everything
> you can so I can give you an "A" :-)
>
> Please explain what's going on and summarize the results of your
> analysis for BZ #14251 so I Can easily review your patch.
>
> e.g.
> http://sourceware.org/glibc/wiki/Contribution%20checklist#Detailed_Exp
> lanation_of_the_Patch
>
> * How do you know MAX_HANDLE_SZ is correct?
You could also mention that this is code copied from x86 ;) The question
still remains whether all values are indeed the same.
> * Testing?
>
> * What does the Power maintainer have to say? I don't see Ryan or
> others on the CC.
Carlos, copying the Power maintainer is not a requriement.
> Thanks for the work!
Thanks,
Andreas
--
Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126