This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch][BZ 14583] Fix prototype of sigsetjmp in pthread.h

On 09/14/2012 11:37 AM, Roland McGrath wrote: 
The declaration is necessary there because the pthread_cleanup_push macro
uses the function.  <pthread.h> is not allowed to include <setjmp.h>, hence
the duplication.
OK.


You should make the prototype match exactly, i.e. [1] vs *.
It might be nice to avoid the duplication by having a common bits/ header
that holds that declaration.  But it seems like overkill for the single
declaration (which is really all pthread.h needs).
Updated patch attached. Only change was to make the prototypes match exactly per your request.

Thanks,
jeff

Attachment: patch
Description: Text document

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]