This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Get rid of ASM_SIZE_DIRECTIVE
- From: Carlos O'Donell <carlos_odonell at mentor dot com>
- To: Marek Polacek <polacek at redhat dot com>
- Cc: Andreas Schwab <schwab at linux-m68k dot org>, <libc-alpha at sourceware dot org>,libc-ports <libc-ports at sourceware dot org>, Kaz Kojima <kkojima at rr dot iij4u dot or dot jp>,Andreas Krebbel <krebbel at linux dot vnet dot ibm dot com>, David Miller<davem at davemloft dot net>, Roland McGrath <roland at hack dot frob dot com>
- Date: Mon, 17 Sep 2012 12:00:33 -0400
- Subject: Re: [PATCH] Get rid of ASM_SIZE_DIRECTIVE
- References: <20120917141912.GE1265@redhat.com> <m2y5k81xkt.fsf@igel.home> <20120917153457.GG1265@redhat.com>
On 9/17/2012 11:34 AM, Marek Polacek wrote:
> On Mon, Sep 17, 2012 at 05:24:50PM +0200, Andreas Schwab wrote:
>> Marek Polacek <polacek@redhat.com> writes:
>>
>>> Removal of ASM_SIZE_DIRECTIVE macro.
>>
>> The macro has some merits in that it avoids repeating the function
>> name. I think it should just be moved out of the sysdep.h files.
>
> This sounds good to. I'd like to hear from Roland first though,
> as he's the one who asked me to do this ;).
I have no opinion one way or the other.
The only problem I have was with the lack of rationale given in the patch email :-)
Cheers,
Carlos.
--
Carlos O'Donell
Mentor Graphics / CodeSourcery
carlos_odonell@mentor.com
carlos@codesourcery.com
+1 (613) 963 1026