Re: [PATCH] [BZ #14462] Fix paths shown by ldconfig -r

[Mike Frysinger <vapier at gentoo dot org>]

On Thursday 13 September 2012 23:42:19 Allan McRae wrote:
>        if (endp == opt_chroot)
>  	opt_chroot = NULL;
> 
> +      chroot_dir = opt_chroot;

seems like this is the only place where chroot_dir is initialized, but you 
always uses it in parse_conf().  and even here, opt_chroot might get turned 
into NULL (i think if you do `ldconfig -r /`).

how about after this opt_chroot processing, you add:
	if (!chroot_dir)
		chroot_dir = "";

then you don't need the NULL check in elf/cache.c, and you can keep opt_chroot 
static in elf/ldconfig.c, and the parse_conf() code works too
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.