This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Get rid of ASM_SIZE_DIRECTIVE


Having helper macros that we use in our code is certainly fine, and
appropriate when code using the macros is more concise, easier to maintain,
etc.  That's a separate issue from de-conditionalizing things.

ASM_SIZE_DIRECTIVE is a useful macro, though it has a very poor choice of
name.  The macro looks like it should expand just to ".size", like the
ASM_GLOBAL_DIRECTIVE expanded just to ".globl".  We don't need a macro for
that.  A shorthand macro is most useful when it has a short name.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]