This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Get rid of ASM_SIZE_DIRECTIVE
- From: Roland McGrath <roland at hack dot frob dot com>
- To: Marek Polacek <polacek at redhat dot com>
- Cc: Andreas Schwab <schwab at linux-m68k dot org>, libc-alpha at sourceware dot org, libc-ports <libc-ports at sourceware dot org>, Kaz Kojima <kkojima at rr dot iij4u dot or dot jp>, Andreas Krebbel <krebbel at linux dot vnet dot ibm dot com>, David Miller <davem at davemloft dot net>
- Date: Mon, 17 Sep 2012 12:25:08 -0700 (PDT)
- Subject: Re: [PATCH] Get rid of ASM_SIZE_DIRECTIVE
- References: <20120917141912.GE1265@redhat.com><m2y5k81xkt.fsf@igel.home><20120917153457.GG1265@redhat.com>
Having helper macros that we use in our code is certainly fine, and
appropriate when code using the macros is more concise, easier to maintain,
etc. That's a separate issue from de-conditionalizing things.
ASM_SIZE_DIRECTIVE is a useful macro, though it has a very poor choice of
name. The macro looks like it should expand just to ".size", like the
ASM_GLOBAL_DIRECTIVE expanded just to ".globl". We don't need a macro for
that. A shorthand macro is most useful when it has a short name.