This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: RFC: Automatically test IFUNC implementations
On Wed, Sep 26, 2012 at 10:01 AM, Richard Henderson <rth@twiddle.net> wrote:
> On 09/26/2012 09:57 AM, H.J. Lu wrote:
>> Relocation section '.rela.text' at offset 0x1110 contains 9 entries:
>> Offset Info Type Sym. Value Sym. Name + Addend
>> 000000000006 000f00000002 R_X86_64_PC32 0000000000000000 .LC0 - 4
>> 000000000023 001400000002 R_X86_64_PC32 0000000000000000 __cpu_features + c
>> 000000000030 001600000004 R_X86_64_PLT32 0000000000000000 malloc - 4
>> 000000000043 001000000002 R_X86_64_PC32 000000000000001d .LC2 - 4
>> 000000000053 001700000002 R_X86_64_PC32 0000000000000000 __memmove_sse2 - 4
>> 000000000076 001600000004 R_X86_64_PLT32 0000000000000000 malloc - 4
>> 000000000082 001100000002 R_X86_64_PC32 0000000000000008 .LC1 - 4
>> 000000000089 001800000002 R_X86_64_PC32 0000000000000000 __memmove_ssse3_ba
>> ck - 4
>> 00000000009c 001900000002 R_X86_64_PC32 0000000000000000 __memmove_ssse3 -
>> 4
>>
>> We can avoid malloc by caller allocates memory on stack.
>
> Looks good, relocation-wise.
>
> A nice macro to compress the initialization of .name and .fn to a single
> line and you should be home free.
>
It is hard to avoid malloc since __libc_func is called from test_init.
I will first convert it to this.
--
H.J.