This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [Patch][BZ 6530] *printf and incomplete multibyte sequences returns-1 bogusly
- From: Carlos O'Donell <carlos_odonell at mentor dot com>
- To: Jeff Law <law at redhat dot com>
- Cc: libc-alpha <libc-alpha at sourceware dot org>
- Date: Fri, 28 Sep 2012 15:37:12 -0400
- Subject: Re: [Patch][BZ 6530] *printf and incomplete multibyte sequences returns-1 bogusly
- References: <5065EF1E.4020807@redhat.com>
On 9/28/2012 2:40 PM, Jeff Law wrote:
> I've reviewed Andreas S.'s patch (as has Jonathan Nieder) and it's
> also the same patch that Rich Felker submitted (as far as I can tell
> independently). I've also reviewed Jonathan's testsuite addition.
>
> Based on the above, I'm approving and installing these changes to fix
> this ANSI compliance issue.
>
> If anyone thinks I'm overstepping here, please let me know.
You are not overstepping your bounds. There is quite a bit of consensus
that the existing code is wrong and that we need to change this.
However, you still need to follow the normal contribution checklist
requirements.
Please post the patch, testing notes, and testcase to the list for
final review.
Cheers,
Carlos.
--
Carlos O'Donell
Mentor Graphics / CodeSourcery
carlos_odonell@mentor.com
carlos@codesourcery.com
+1 (613) 963 1026