This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH] nptl_db/Makefile: force C locale when running readelf


db-symbols.awk relies on English-language readelf output to find the
beginning of the symbol table, so force the locale.

Without this change, "make check" fails in non-English locales:

| diff -p -U 0 ../sysdeps/unix/sysv/linux/x86_64/64/nptl/libthread_db.abilist [...]/nptl_db/libthread_db.symlist
| readelf -W -s [...]/nptl/libpthread.so | gawk -f [...]/nptl_db/db-symbols.v.i > [...]/nptl_db/db-symbols.out
| make[2]: *** [[...]/nptl_db/db-symbols.out] Erreur 1
---
2012-10-08  Jonathan Nieder  <jrnieder@gmail.com>

	[BZ #14661]
	* Makefile ($(objpfx)db-symbols.out): Force C locale when running
	readelf -s.

 nptl_db/ChangeLog |    6 ++++++
 nptl_db/Makefile  |    2 +-
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/nptl_db/Makefile b/nptl_db/Makefile
index d15fb9e8..6ccb3d0c 100644
--- a/nptl_db/Makefile
+++ b/nptl_db/Makefile
@@ -60,6 +60,6 @@ $(objpfx)libthread_db.so: $(common-objpfx)libc.so \
 tests: $(objpfx)db-symbols.out
 $(objpfx)db-symbols.out: $(objpfx)db-symbols.v.i \
 			 $(common-objpfx)nptl/libpthread.so
-	readelf -W -s $(filter %.so,$^) | $(AWK) -f $< > $@
+	LC_ALL=C readelf -W -s $(filter %.so,$^) | $(AWK) -f $< > $@
 
 $(objpfx)db-symbols.v.i: db-symbols.awk


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]