This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] disable var-tracking for math/test-tgmath2.c


On 10/18/2012 3:15 PM, David Miller wrote:
> From: Markus Trippelsdorf <markus@trippelsdorf.de>
> Date: Thu, 18 Oct 2012 21:00:02 +0200
> 
>> I really doubt that any sane user uses lines with over 3 million
>> characters like this test case does.
> 
> Agreed.
> 
> The proposed change has zero impact on the effectiveness of this
> test case.
> 

Disagree.

I see auto-generated code that does this all the time.

However, I do not disagree that *today* the proposed change
has likely zero impact on the effectiveness of the change.

Today is not what worries me.

Tomorrow worries me.

I would accept:

(a) Splitting out some of these functions into new tests,
    and then marking a smaller subset with -fno-var-tracking
    (Roland's suggestion). This reduces the effect of the
    hack.

(b) Leaving it as-is with a comment in the Makefile.

I've checked in your patch which does (b).

Look forward to seeing (a) from someone.

Thanks for the comment update.

diff --git a/ChangeLog b/ChangeLog
index f8be4dd..5af0503 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@
+2012-10-18  Markus Trippelsdorf  <markus@trippelsdorf.de>
+
+       * math/Makefile: Comment on slow compilation of test-tgmath2.c.
+
 2012-10-18  Joseph Myers  <joseph@codesourcery.com>

        * sysdeps/generic/_G_config.h (_G_OPEN64): Remove.
diff --git a/math/Makefile b/math/Makefile
index 7759873..9e17695 100644
--- a/math/Makefile
+++ b/math/Makefile
@@ -126,6 +126,9 @@ CFLAGS-test-float.c = -fno-inline -ffloat-store -fno-builtin -frounding-math
 CFLAGS-test-double.c = -fno-inline -ffloat-store -fno-builtin -frounding-math
 CFLAGS-test-ldouble.c = -fno-inline -ffloat-store -fno-builtin -frounding-math
 CFLAGS-test-tgmath.c = -fno-builtin
+# The following testcase uses very long lines (>3 million), so it may take a
+# while to compile it. See: http://llvm.org/bugs/show_bug.cgi?id=14106 and
+# http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54402
 CFLAGS-test-tgmath2.c = -fno-builtin
 CFLAGS-test-tgmath-ret.c = -fno-builtin
 CFLAGS-test-powl.c = -fno-builtin
---

Cheers,
Carlos.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]