This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Include <stdint.h> when using SIZE_MAX or SSIZE_MAX.
On 10/20/2012 06:11 AM, maxim@codesourcery.com wrote:
From: Maxim Kuvyrkov <maxim@codesourcery.com>
* libio/iogetdelim.c, sysdeps/posix/preadv.c, sysdeps/posix/pwritev.c
* sysdeps/posix/readv.c, sysdeps/posix/writev.c, time/tzfile.c: Include
stdint.h for SIZE_MAX or SSIZE_MAX.
Please follow our conventions for ChangeLog entries and have a line for
each file, e.g.:
* libio/iogetdelim.c: Include stdint.h for SIZE_MAX or
SSIZE_MAX.
* sysdeps/posix/preadv.c: Likewise.
...
It looks like you forgot to update the copyright years for some of the
files, please consolidate them as explained here:
http://sourceware.org/glibc/wiki/Contribution%20checklist#Update_Copyright_Information
The patch is fine with the above changes,
Thanks,
Andreas
--
Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126