This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Sharing of bits/fcntl.h on Linux (SPARC, x86)
On 10/23/2012 08:26 PM, Roland McGrath wrote:
-#if defined __USE_XOPEN || defined __USE_XOPEN2K
/* The Single Unix specification says that some more types are
available here. */
Update this comment. SUS is relevant to those feature test macros, not to
anything else. It should say "POSIX.1-yyyy says that these types are
defined here", for whatever yyyy is appropriate (and an exact citation
wouldn't hurt). Joseph said that "newer POSIX" changed the requirement
about this, but I don't know the specifics of what he was referring to.
Joseph, what exactly should I reference here?
The substance looks fine to me.
Could you also review the patch "F_GETLK etc. cleanup for
<bits/fcntl.h>"? Then I can work again on the architecture specific files...
Thanks,
Andreas
--
Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126