This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] BZ #14782 system async cancellation


On Thu, Nov 01, 2012 at 06:23:36PM +0530, Siddhesh Poyarekar wrote:
> On Thu, 1 Nov 2012 08:35:45 -0400, Rich wrote:
> > Could you please clarify. FORK does not appear anywhere else in either
> > of these two files except the #ifdef in sysdeps/posix/system.c, where
> > it's intended that the code in the #else clause be used.
> 
> FORK is defined for various architectures as well, so you need to

Where? The existence of FORK as a way to provide an alternate for
__fork is not any inherent problem anyway; the problem (which isn't
really a problem anyway, just gratuitous code complexity) is just the
use of clone with special flags in place of fork on Linux.

> remove those, without which your patch is incomplete.  Easy first step
> would be to simply remove the #ifdef FORK from sysdeps/posix/system.c
> so that the use of FORK is explicitly eliminated, after which the
> architecture specific sysdep files can be eliminated.  Not sure if that
> is what Andreas referred to.

I'm unsure if it's needed by other files which include this one; it
certainly isn't hurting anything to leave it, but I'll admit that it
may be possible to simplify the code further. Doing so is independent
from fixing the bug.

Rich


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]