This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Support --with-pkgversion and --with-bugurl


On Fri, 9 Nov 2012, Roland McGrath wrote:

> > diff --git a/sunrpc/proto.h b/sunrpc/proto.h
> > index 0ba9cd6..ea28565 100644
> > --- a/sunrpc/proto.h
> > +++ b/sunrpc/proto.h
> > @@ -62,7 +62,4 @@ void add_type(int len, const char *type);
> >  #define _(X) (X)
> >  #define textdomain(X) ((void) 0)
> >  
> > -/* This is used in the definition of PACKAGE for --version output.  */
> > -#define _libc_intl_domainname "libc"
> > -
> >  #endif
> 
> These seems unrelated.  If it doesn't break either the build or the rpcgen
> built to be installed, it's a fine change.  But it shouldn't be part of
> this commit.

This *is* related: the code previously used PACKAGE, which uses 
_libc_intl_domainname, and the patch makes it use PKGVERSION instead, 
which will always be a string constant, so defining _libc_intl_domainname 
for cross-rpcgen is no longer needed after the patch, but is needed before 
the patch.  While it could go in separately after the main pkgversion 
changes (but not before them), splitting it out like that seems pointless 
to me.

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]