This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH,HURD] fix muntrace with mmap-less libio
- From: Roland McGrath <roland at hack dot frob dot com>
- To: Pino Toscano <toscano dot pino at tiscali dot it>
- Cc: libc-alpha at sourceware dot org, bug-hurd at gnu dot org
- Date: Mon, 19 Nov 2012 09:35:47 -0800 (PST)
- Subject: Re: [PATCH,HURD] fix muntrace with mmap-less libio
- References: <201211172058.21035.toscano.pino@tiscali.it>
That change is good but it needs a comment. You don't need to go into
great detail, just say that we call fprintf+fclose after clearing the
hooks to match how mtrace called fopen+fprintf before setting them.
Thanks,
Roland