This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] PowerPC - Fix build with linux 3.7 headers
On Fri, Nov 23, 2012 at 8:02 AM, Josh Boyer <jwboyer@gmail.com> wrote:
> On Thu, Nov 22, 2012 at 11:07 PM, Adam Conrad <adconrad@0c3.net> wrote:
>> The following simple patch fixes the build against linux 3.7 headers,
>> where _ASM_POWERPC_ELF_H was renamed to _UAPI_ASM_POWERPC_ELF_H.
>>
>> Already tested and working in the current Ubuntu development series.
>>
>> 2012-11-22 Adam Conrad <adconrad@0c3.net>
>>
>> * sysdeps/unix/sysv/linux/powerpc/sys/procfs.h: Support
>> _UAPI_ASM_POWERPC_ELF_H in the Linux 3.7 headers.
>>
>> ---
>
> I wouldn't commit this. It is arguably a bug in the kernel headers and
> there is already a patch sent to fix it. See here:
>
> http://article.gmane.org/gmane.linux.kernel.cross-arch/15847
>
> I believe Andrew Morton already queued this up.
>
> I have no authority in glibc at all, but I'd NAK this for now if I did.
Josh,
No true, you reviewed the patch, and made a comment. That counts.
Adam,
Has this bug made it into a release kernel that glibc could possibly
be built with?
The obvious implication being that users might try to use such a kernel
and that the patch would prevent a build failure there.
Cheers,
Carlos.