This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Improve C++ header detection in configure


On Fri, Nov 23, 2012 at 03:59:15PM -0500, Carlos O'Donell wrote:
> 
> Some systems, namely gentoo, uses `g++-v4' (on hppa at least) as the
> C++ header path segment. This leads me to believe that the path is
> less likely to always be `c++'. However, there has always been a
> `/.++' in the C++ header path, so lets stick with that. Therefore it
> looks like what we want is 's/^ \(\/.*\/.++.*\)/\1/p'

That last .* is unnecessary, it's implied without a $-termination.  As
for the single-char match, I'm having a hard time believing anyone
installed headers to, say, /path/to/q++-v3, so perhaps a more restrictive
match would be sane, like:

's/^ \(\/.*\/[cg]++\)/\1/p'

Or, if you meant your last .* to match, say, -v4, but still allow the
closing / that I had:

's/^ \(\/.*\/[cg]++.*\/\)/\1/p'

Thoughs?

... Adam


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]