This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] PowerPC - Fix build with linux 3.7 headers
On Fri, Nov 23, 2012 at 4:16 PM, Carlos O'Donell
<carlos@systemhalted.org> wrote:
> On Fri, Nov 23, 2012 at 3:49 PM, Adam Conrad <adconrad@0c3.net> wrote:
>> On Fri, Nov 23, 2012 at 11:18:17AM -0500, Carlos O'Donell wrote:
>>> On Fri, Nov 23, 2012 at 11:16 AM, Josh Boyer <jwboyer@gmail.com> wrote:
>>> >
>>> > As noted in the kernel patch, glibc is looking for specific header
>>> > guard defines in various kernel headers. If the kernel ships with the
>>> > UAPI prefix in the installed headers, a more in-depth audit of which
>>> > kernel header guards are looked at is probably needed.
>>>
>>> Agreed, but an in-depth audit should not block incremental or immediate
>>> progress, and I would consider this patch incremental progress.
>>
>> This is a real problem today with 3.7-rc headers, but I'm happy to
>> shelve it and carry a local patch while we see if this ends up this
>> way in 3.7-final. If it does, I'll follow-up (and/or just commit,
>> if anyone want to pre-approve on that condition?), and if the rename
>> mangling happens, I'll just drop the proposal and my local patch.
>>
>> Sound fair?
>
> Yes. Actually I want this checked in as bug-fix even after we freeze
> for the 2.17 release.
>
> The 3.7 kernel should come out in 7-14 days, so I want this fix in
> 2.17 if the kernel isn't fixed.
The kernel fix for this went into Linus' tree yesterday as:
commit 56c176c9cac9a77249fa1736bfd792f379d61942
Author: David Howells <dhowells@redhat.com>
Date: Mon Nov 26 16:29:39 2012 -0800
UAPI: strip the _UAPI prefix from header guards during header installation
and will be included in the final 3.7 release. Whew.
josh