This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [COMMITTED PATCH] Bug fixes: hppa: Implement socket_type.h /hppa: Cleanup cast warnings.
- From: "Carlos O'Donell" <carlos at systemhalted dot org>
- To: Roland McGrath <roland at hack dot frob dot com>
- Cc: libc-alpha <libc-alpha at sourceware dot org>
- Date: Thu, 29 Nov 2012 17:58:21 -0500
- Subject: Re: [COMMITTED PATCH] Bug fixes: hppa: Implement socket_type.h /hppa: Cleanup cast warnings.
- References: <50B7E575.3030503@systemhalted.org><20121129225138.BD7AC2C0B9@topped-with-meat.com>
On Thu, Nov 29, 2012 at 5:51 PM, Roland McGrath <roland@hack.frob.com> wrote:
>> + * sysdeps/unix/sysv/linux/hppa/bits/socket.h: Delete file.
>> + * ports/sysdeps/unix/sysv/linux/hppa/bits/socket_type.h: New file.
>
> s,ports/,,
Thanks.
Fixed as distinct commit with trailing whitespace cleanup.
>> @@ -42,7 +42,7 @@ feholdexcept (fenv_t *envp)
>>
>> /* Load the new environment. Note: fr0 must load last to enable T-bit
>> Thus we start bufptr at the end and work backwards */
>> - bufptr = (unsigned int)(clear.buf) + sizeof(unsigned int)*4;
>> + bufptr = (unsigned long long *)((unsigned int)(clear.buf) + sizeof(unsigned int)*4);
>
> libc code eschews implicit int (but uint64_t might be the easier thing to
> type anyway), and also uses more spaces than this.
Thanks, I've put this on my todo list.
(ae) Cleanup feholdexcept explicit int and use uint64_t.
Cheers,
Carlos.