This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Don't treat tls_offset == 1 as forced dynamic
- From: David Miller <davem at davemloft dot net>
- To: law at redhat dot com
- Cc: schwab at suse dot de, libc-alpha at sourceware dot org
- Date: Fri, 07 Dec 2012 15:05:51 -0500 (EST)
- Subject: Re: [PATCH] Don't treat tls_offset == 1 as forced dynamic
- References: <mvmd2yq6tbx.fsf@g208.suse.de><50C02437.7010909@redhat.com>
From: Jeff Law <law@redhat.com>
Date: Wed, 05 Dec 2012 21:51:03 -0700
> On 12/04/2012 02:48 AM, Andreas Schwab wrote:
>> A TLS offset of 1 is a valid one, so it cannot be used as a marker to
>> force dynamic tls block allocation. A valid tls_offset is never
>> negative, so use -1 as the marker instead.
>>
>> Andreas.
>>
>> [BZ #14898]
>> * include/link.h (FORCED_DYNAMIC_TLS_OFFSET) [NO_TLS_OFFSET == 0]:
>> Change to -1.
> FYI for David M.
>
> If we could get this into 2.17 it'd be useful. In addition to fixing
> 14898 it fixes a downstream bug in Fedora (731228). It's been in
> Fedora since Sept 2011.
Ok, please install this change.