This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Don't check ABI for _nl_default_dirname


On Sat, Dec 8, 2012 at 2:12 AM, Siddhesh Poyarekar <siddhesh@redhat.com> wrote:
> On Fri, Dec 07, 2012 at 09:02:15PM -0800, Andi Kleen wrote:
>> From: Andi Kleen <ak@linux.intel.com>
>>
>> As discussed in http://comments.gmane.org/gmane.comp.lib.glibc.alpha/24671
>>
>> The ABI of _nl_default_dirname depends on the prefix glibc is compiled with.
>> For glibcs with non standard prefix _nl_default_dirname changes,
>> which causes the ABI check in make check to fail.
>>
>> The workaround of always configuring with --prefix=/usr didn't really
>> work for me because I would have needed to reconfigured/recompiled
>> glibc to do any testing outside the test suite.
>
> The discussion above concluded that it would be a better idea to make
> the abi check a little smarter, than to remove tests.  It would be
> nicer if the abilist file format is extended to denote data symbols
> that are a function of configuration variables and adjust
> expectations.  It's a non-trivial task but I'd think of that as the
> way forward.

Andi,

I fully agree that it is a problem that we can't pass the
testsuite cleanly in all possible configurations.

However, removing _nl_default_dirname from the ABI check
makes this test weaker for all the other people who are
configuring with a fixed prefix.

ABI checking is something for which our project is extremely
conservative.

It is not acceptable to me to simply remove the offending
symbol. We need incremental progress towards a fix.

If you don't have the time for this work, please file a bug
for this, mark it milestone 2.18 and a priority that matches
your requirements. I'll have a look at the issue as part of
our 2.18 planning.

Cheers,
Carlos.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]